fix(config): remove spurious error log from tryDecode on decode failure#692
Closed
mdryaan wants to merge 1 commit into
Closed
fix(config): remove spurious error log from tryDecode on decode failure#692mdryaan wants to merge 1 commit into
mdryaan wants to merge 1 commit into
Conversation
Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
|
Hello @mdryaan , once more please do not open PRs for unverified issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tryDecode()inpkg/unikontainers/config.gologs at error level when base64 decoding fails. Since annotation values like"qemu"or"unikraft"are plain text, this fires on every container start — not a real error.The fallback to the original string is the intended behavior. Removed the log call entirely.
Related issues
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).